Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(structure): add timeout to reconnecting message #7531

Merged
merged 4 commits into from
Sep 24, 2024
Merged

refactor(structure): add timeout to reconnecting message #7531

merged 4 commits into from
Sep 24, 2024

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Sep 20, 2024 •
edited
Loading

Description

Add a timeout to the toast message so that it doesn't trigger immediately.

Testing

In any doc you can use window.stop() in the dev console which will set the studio state to trigger the reconnecting state

Notes for release

Add timeout to reconnecting message

@RitaDias RitaDias requested a review from a team as a code owner September 20, 2024 11:03
@RitaDias RitaDias requested review from ricokahler and removed request for a team September 20, 2024 11:03
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:46am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:46am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:46am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:46am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 11:46am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Component Testing Report Updated Sep 24, 2024 11:48 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 39s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RitaDias RitaDias force-pushed the corel-173 branch 2 times, most recently from 6c8c0d4 to 3fca17a Compare September 24, 2024 10:09
@RitaDias @bjoerge
chore(structure): update type
94cbe8c 
Co-authored-by: Bjørge Næss <[email protected]>
@RitaDias RitaDias added this pull request to the merge queue Sep 24, 2024
Merged via the queue into next with commit 9ab4086 Sep 24, 2024
42 checks passed
@RitaDias RitaDias deleted the corel-173 branch September 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

@ricokahler ricokahler Awaiting requested review from ricokahler ricokahler was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RitaDias @bjoerge